ZO-4649: Configure max retry for speech webhook #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louika
commented
Feb 13, 2024
| self.retry(countdown=int(config['retry-delay-seconds'])) | ||
| self.retry( | ||
| countdown=int(config['retry-delay-seconds']), max_retries=int(config['max-retries']) | ||
| ) |
There was a problem hiding this comment.
should work with config instead of at task level https://docs.celeryq.dev/en/stable/reference/celery.app.task.html#celery.app.task.Task.retry
wosc
requested changes
Feb 13, 2024
core/docs/changelog/ZO-4683.change
Outdated
| @@ -0,0 +1 @@ | |||
| ZO-4683: Only publish article after referencing tts audio if it is unchanged | |||
There was a problem hiding this comment.
Das gehört nicht hier rein, oder? Ansonsten passt alles.
There was a problem hiding this comment.
oh absolut nicht, was hat das da zu suchen
louika
force-pushed
the
ZO-4649_max_retries
branch
from
c4ffe57
to
32992d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retry period for the celery task should cover one hour.
Checklist
Translationsgif